Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: dice icon #813

Closed
wants to merge 1 commit into from
Closed

Feat: dice icon #813

wants to merge 1 commit into from

Conversation

imlinus
Copy link

@imlinus imlinus commented Jan 15, 2020

No description provided.

@imlinus imlinus mentioned this pull request Jan 15, 2020
Open
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #813 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #813   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91118a6...fcd9091. Read the comment docs.

locness3
locness3 reviewed Jan 15, 2020
View reviewed changes
Copy link

@locness3 locness3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks weird on the github preview :/ Also, why are you modifying the twitch icon too?
Screenshot_2020-01-15 Feat dice icon by imlinus · Pull Request #813 · feathericons feather

n1ru4l
n1ru4l reviewed May 28, 2020
View reviewed changes
Copy link

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2020-05-28 at 18 01 09

The SVG seems okay when opened within chrome. But looks weird when rendered as a react component (the same as it looks like on Github preview)

@johnletey johnletey mentioned this pull request May 28, 2020
Closed
@ericfennis ericfennis mentioned this pull request Jun 16, 2020
Closed
@imlinus imlinus closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ru4l n1ru4l n1ru4l left review comments

@locness3 locness3 locness3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imlinus @n1ru4l @locness3