Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dice icon #918

Closed
wants to merge 1 commit into from
Closed

feat: Add dice icon #918

wants to merge 1 commit into from

Conversation

johnletey
Copy link

This PR is a follow up from #813. @imlinus deleted his forked repo, so there is no way to make any further changes to his PR, which is needed.

Closes #812


#813 (review)

@n1ru4l does this resolve your issue?

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #918 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           34        34           
  Branches         3         3           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15b4a7...9b24d40. Read the comment docs.

Copy link

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better but I think the dots could be a bit bigger

@imlinus
Copy link

imlinus commented May 29, 2020

Thank you for the help with this one.
I'm really not a designer and should probably never open Figma again :-D

@johnletey
Copy link
Author

I'm really not a designer and should probably never open Figma again :-D

@imlinus We all start from somewhere! I'm far from being a designer! If you want to take my work and open another PR go for it, as it was your icon that I tweaked a bit.

@colebemis colebemis deleted the branch feathericons:master August 19, 2023 22:45
@colebemis colebemis closed this Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dice
4 participants