Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

Fix default authentication config keys #506

Merged
merged 5 commits into from Jun 8, 2017
Merged

Fix default authentication config keys #506

merged 5 commits into from Jun 8, 2017

Conversation

ekryski
Copy link
Member

@ekryski ekryski commented May 10, 2017

Summary

The default config key was changed to authentication and was not updated here. This fixes that. This isn't a breaking change for anyone using v2 of the generator and/or are passing their auth config explicitly when configuring auth plugins:

const config = app.get('auth');
app.configure(authentication(config));

but it will be for people that migrated to the new version of auth and still have a config file with:

"auth": {
   // auth config values
}

instead of:

"authentication": {
   // auth config values
}

For that reason, this and the associated PRs will need to be major releases:

@marshallswain
Copy link
Member

marshallswain commented May 10, 2017

Why not ease the burden with a var authConfig = app.get('auth') || app.get('authentication') and merge that in, instead? We'll have some cleanup work to do as tech support, otherwise.

@ekryski ekryski mentioned this pull request May 19, 2017
6 tasks
@ekryski
Copy link
Member Author

ekryski commented Jun 1, 2017

@marshallswain Ah shit sorry. I didn't even see your comment. That's a good idea.

@marshallswain marshallswain changed the title Fix 497 Fix default authentication config keys Jun 8, 2017
@marshallswain marshallswain merged commit 79c5be1 into master Jun 8, 2017
@ekryski
Copy link
Member Author

ekryski commented Jun 8, 2017

:shipit:

@marshallswain marshallswain deleted the fix-497 branch June 8, 2017 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants