This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Fixing client query #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good. I've got some changes coming in a PR that does the same thing plus some others on the back end side that you are probably unaware of and also adds some tests. Just give me another 15 minutes or so. |
|
Thanks so much for your help @fastlorenzo! I'm going to close this in favour of #67 because there is actually a bit more that needed to happen to clean up dead code and I thought it would be faster if I just do it rather than explaining everything that needed to be removed and why. |
|
Fuck it. I'll merge it to give credit where it is due. Thanks @fastlorenzo! |
|
Atta boy! :) |
ekryski
added a commit
that referenced
this pull request
Feb 15, 2016
Removing assigning token to params.query for sockets. Closes #65.
|
Haha thanks @ekryski |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #64