Feature request: Customizing the query

[mikeconley12]

It would be great to have an ability to customize the query. See the Knex service adapter docs for details

[dekelev]

You do have the ability. Use modifiers methods in your model and run them on queries with $modify. בתאריך שבת, 17 באוק׳ 2020, 16:18, מאת mikeconley12 ‏< notifications@github.com>:

…

It would be great to have an ability to customize the query. See the Knex service adapter docs <https://github.com/feathersjs-ecosystem/feathers-knex#customizing-the-query> for details — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#123>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB5E3NEFRXPK7MNAVWWJMDSLGKTBANCNFSM4SULPBZQ> .

[mikeconley12]

Thanks for your answer! I will check the modifiers in a few days and close this issue or explain why it doesn't work.

[mikeconley12]

Hi @dekelev ! I have a question.
How can I specify multiple modifiers with different arguments?

I need an equivalent to this:

const women = await Person.query()
  .modify('filterAge', 18)
  .modify('filterGender', 'female');

[dekelev]

You can add 2 modifiers to the model and when calling find on the service, add params.query.$modify=modifier1_fn_name,modifier2_fn_name Check the docs for examples. בתאריך יום א׳, 18 באוק׳ 2020, 19:07, מאת mikeconley12 ‏< notifications@github.com>:

…

Hi @dekelev <https://github.com/dekelev> ! I have a question. How can I specify multiple modifiers with different arguments? I need an equivalent to this: const women = await Person.query() .modify('filterAge', 18) .modify('filterGender', 'female'); — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB5E3OKDS6G4LVPIVTEDOTSLMHDNANCNFSM4SULPBZQ> .

[dekelev]

Passing arguments to modifiers is supported too, but I think you'll need to use array for that. בתאריך יום א׳, 18 באוק׳ 2020, 20:01, מאת Dekel ‏<dekelev@gmail.com>:

…

You can add 2 modifiers to the model and when calling find on the service, add params.query.$modify=modifier1_fn_name,modifier2_fn_name Check the docs for examples. בתאריך יום א׳, 18 באוק׳ 2020, 19:07, מאת mikeconley12 ‏< ***@***.***>: > Hi @dekelev <https://github.com/dekelev> ! I have a question. > How can I specify multiple modifiers with different arguments? > > I need an equivalent to this: > > const women = await Person.query() > .modify('filterAge', 18) > .modify('filterGender', 'female'); > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#123 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABB5E3OKDS6G4LVPIVTEDOTSLMHDNANCNFSM4SULPBZQ> > . >

[mikeconley12]

yes, I checked the docs. But I need different arguments for each modifier. Is it possible?

params.query.$modify = { "modifier1_fn_name": ["args1"], "modifier2_fn_name": ["args2"] };

[dekelev]

Yes, it's possible בתאריך יום א׳, 18 באוק׳ 2020, 20:15, מאת mikeconley12 ‏< notifications@github.com>:

…

yes, I checked the docs. But I need different arguments for each modifier. Is it possible? params.query.$modify = { "modifier1_fn_name": ["args1"], "modifier2_fn_name": ["args2"] }; — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB5E3LCKRQ6ZJ6OSPV54TTSLMPB7ANCNFSM4SULPBZQ> .

[dekelev]

Check the test file for usage examples. בתאריך יום א׳, 18 באוק׳ 2020, 20:44, מאת Dekel ‏<dekelev@gmail.com>:

…

Yes, it's possible בתאריך יום א׳, 18 באוק׳ 2020, 20:15, מאת mikeconley12 ‏< ***@***.***>: > yes, I checked the docs. But I need different arguments for each > modifier. Is it possible? > > params.query.$modify = { "modifier1_fn_name": ["args1"], "modifier2_fn_name": ["args2"] }; > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#123 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABB5E3LCKRQ6ZJ6OSPV54TTSLMPB7ANCNFSM4SULPBZQ> > . >

[mikeconley12]

Sorry, but I already checked this test file and I didn't find a solution.

For example, I see here multiple modifiers, but all the modifiers have the same arguments.

[dekelev]

https://github.com/feathersjs-ecosystem/feathers-objection/blob/0f4a36702a4b134933650afd81d2bafaaa5812f5/test/index.test.js#L2097 Each item in the array is an array that its first item is the modifier name and rest of items are args for that modifier. בתאריך יום א׳, 18 באוק׳ 2020, 21:03, מאת mikeconley12 ‏< notifications@github.com>:

…

Sorry, but I already checked this test file <https://github.com/feathersjs-ecosystem/feathers-objection/blob/master/test/index.test.js> and I didn't find a solution. For example, I see here <https://github.com/feathersjs-ecosystem/feathers-objection/blob/master/test/index.test.js#L2105> multiple modifiers, but all the modifiers have the same arguments. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB5E3NYEYEG4VG47JU673LSLMUWHANCNFSM4SULPBZQ> .

[mikeconley12]

and rest of items are args for that modifier

No, in your example, large is a modifier

feathers-objection/test/company.js

Line 53 in dbd6e44

large: (builder, hasCeo) => {

Also see Objection.js documentation. It says that the first argument is a modifier, and the rest are arguments passed to the modify function

[dekelev]

Right, so I'll add support for JSON object as value for $modify and we'll be able to use it as you suggested and without a breaking-change:

{ "modifier1_fn_name": ["args1"], "modifier2_fn_name": ["args2"] }

It's also much more readable in my opinion, so it would also be my default value type for $modify.
I'll add examples to the docs once it's ready, but basically it's a low effort task, so I hope to release it later today.

[mikeconley12]

It's awesome! Thank you! But will it be a JSON string? Or just a regular JS object?

[dekelev]

It will also support stringified JSON object. בתאריך יום ב׳, 19 באוק׳ 2020, 13:08, מאת mikeconley12 ‏< notifications@github.com>:

…

It's awesome! Thank you! But will it be a JSON string? Or just a regular JS object? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABB5E3PNCCJWKDFCYKG5L5DSLQF2ZANCNFSM4SULPBZQ> .

[dekelev]

Released with v6.1.0

I've updated the $modify docs as well. enjoy!

[mikeconley12]

Great, thanks for your help!