New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account the idColumn for objection models when creating the adapter #40

Closed

csotiriou wants to merge 1 commit into feathersjs-ecosystem:master from csotiriou:bugfix/model_column_id_fix

csotiriou commented Feb 10, 2019

This small patch takes into account the 'idColumn' of an objection model.

This allows making updates and .get() requests in the service while having a key other than the default one, or a composite key.

Objection documentation for idColumn: http://vincit.github.io/objection.js/#idcolumn


          Take into account the idColumn for objection models when creating the…

3efe4f6

… adapter

coveralls commented Feb 10, 2019 •

edited

Loading

Pull Request Test Coverage Report for Build 274

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 96.449%

Totals
Change from base Build 272:	-0.2%
Covered Lines:	282
Relevant Lines:	285

💛 - Coveralls

csotiriou mentioned this pull request

Library cannot handle ID columns with names other than the default #41

Closed

Member

dekelev commented Feb 15, 2019

https://github.com/feathersjs-ecosystem/feathers-objection/releases/tag/v3.1.2

dekelev closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment