-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
items not being removed from the list - fix proposal #12
Comments
Seems like a good fix to me. Care to start a PR? I can try to add a test for this. |
fix item removal in addOrUpdateList (feathersjs-ecosystem#12)
Hi, there is still an issue with deleting items through services, the list does not update. I have created a service called |
I found out the issue. It was not with the service but I had defined the |
I noticed that when I have 2 browsers open and remove item in one browser, the other one doesn't react to the removal although it gets the notification when using -reactive extension. Same thing happens when re-querying the data and having some deleted records in the meantime between refresh: the list only gets additions and removals are kept.
So I updated the action addOrUpdateList with the removal logic (see comments).
Could there be some side-effects of changing this I could not see?
The text was updated successfully, but these errors were encountered: