addItems mutation fix tempId #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `tempId` was assigned before calling `addItems`-mutation -> `tempId` is undefined -> `newTempsById[undefined] = item`
| if (!item[tempIdField]) { | ||
| var tempId = assignTempId(state, item) | ||
| let tempId = item[tempIdField]; | ||
| if (!tempId) { |
There was a problem hiding this comment.
Please change this to if(tempId == null) { so it will work with falsey, but valid, ids.
|
Thanks for the great catch. I've made one comment. If you could update that tempId |
works with falsey tempId
|
Didn't think of that. Changed it. Thank you |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I'm programming an progressive web app with feathers-vuex and localForage. I stumbled upon this. I wanted to restore
keyedByIdfrom IndexedDB by usingaddItems. Instead of just overwriting the storeskeyedByIdby the IndexedDB ones, I wanted to have them as Vuex-Models :)This little change should fix the problem. Everything works for me now.
If
tempIdwas assigned before callingaddItems-mutation ->tempIdis undefined ->newTempsById[undefined] = itemAgain thanks for this great module! <3