Adds feathers-rpc #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This lightweight middleware enables RPC style verbs on Feathers routes that then can (optionally) trigger custom methods. This allows custom-method calls when external systems cannot modify header requests and leverage
x-service-method.This problem originated from integration issues with legacy webhook software and tooling. By enabling path-only custom method triggers, there's no need to pollute the
request.bodywith special fields.Other Information
This has been tested with both Koa and Express in v5, and Express only in v4. Automated tests use integration tests for Koa and Express in v5 only. Will expand to v4 as necessary.