Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SocketIO default configuration #19

Closed
daffl opened this issue Sep 27, 2013 · 3 comments
Closed

Remove SocketIO default configuration #19

daffl opened this issue Sep 27, 2013 · 3 comments
Milestone

Comments

@daffl
Copy link
Member

daffl commented Sep 27, 2013

We should investigate if the SocketIO default configuration for transports should be changed to websockets first (or what other options make sense for production settings).

io.set('transports', [
  'xhr-polling', 'websocket', 'flashsocket',
  'htmlfile', 'jsonp-polling'
]);
@daffl
Copy link
Member Author

daffl commented Oct 22, 2013

This should indeed use the recommended production settings for the app production environment:

io.enable('browser client minification');  // send minified client
io.enable('browser client etag');          // apply etag caching logic based on version number
io.enable('browser client gzip');          // gzip the file
io.set('log level', 1);                    // reduce logging

// enable all transports (optional if you want flashsocket support, please note that some hosting
// providers do not allow you to create servers that listen on a port different than 80 or their
// default port)
io.set('transports', [
    'websocket'
  , 'flashsocket'
  , 'htmlfile'
  , 'xhr-polling'
  , 'jsonp-polling'
]);

@daffl
Copy link
Member Author

daffl commented Jan 3, 2014

In fact we should probably not bother doing any SocketIO configuration at all, removing it and documenting it instead.

@daffl daffl closed this as completed in c544515 Jan 3, 2014
daffl pushed a commit that referenced this issue Aug 21, 2018
daffl pushed a commit that referenced this issue Aug 21, 2018
daffl pushed a commit that referenced this issue Aug 23, 2018
daffl pushed a commit that referenced this issue Aug 25, 2018
Fixing error "choosing your own db"
daffl added a commit that referenced this issue Aug 25, 2018
daffl added a commit that referenced this issue Aug 28, 2018
* chore(package): update chai to version 4.0.2

Closes #19

* Use latest sinon-chai
daffl added a commit that referenced this issue Aug 29, 2018
* chore(package): update chai to version 4.0.2

Closes #19

* Use latest sinon-chai
@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant