different count of arguments in service method from rest api and socket api calling

[Vitaliy-Yarovuy]

than i create "Services" and use socket client it send 2 arguments to "get" method of Service but than i use REST api it call with 3 arguments?
what i do wrong ?

[daffl]

Just pass the same number of arguments when emitting the SocketIO event by using an empty object as the parameters:

var myService = {
  get: function(id, params, callback) {

  }
}

socket.emit('todo::get', 1, {}, function() {});

You can also write your service method so that it works both ways:

var myService = {
  get: function(id, params, callback) {
    if(!callback) {
      callback = params;
      params = {};
    }
  }
}

socket.emit('todo::get', 1, function() {});

[Vitaliy-Yarovuy]

when i send 4 argument on web browser it not working

socket.emit("testpoints::get", $scope.pointId,{},function(err, point){
    $scope.point = point;
});

socket.io is using xhr-poling
and header "Request Payload" have value:

5:1+::{"name":"testpoints::get","args":["one"]}

and header the same in both way when i use 3 argument and when 4 arguments
for method socket.emit.

and in both type of calling on web browser client, on server i have only 2 arguments on "get" method than i use socket.io client

[daffl]

I'm not sure I am following here. I just tried it with the example from the website and something like

socket.emit('todos::get', 1, {}, function(error, todo) {})

Most definitely works. How does your testpoints service .get look like?
As noted in #19, using long polling as the default setting isn't entirely correct so that setting will change in the next version.

[Vitaliy-Yarovuy]

I have solve this problem (for me) in my code, but is not work like in documentation.

my service get looks

TestPointService.prototype.get = function (id) {
    var callback = arguments[arguments.length-1];
    if (!this.testPoints[id]) {
        this.create({id:id},function(){});
    }
    callback(null, this.testPoints[id]);
};

[daffl]

What part of the documentation are you referring to? As I pointed out in my comment above

TestPointService.prototype.get = function(id, params, callback) {
  if(!callback) {
    callback = params;
    params = {};
  }
  // Do stuff here
}

Should do the same as your solution. I highly recommend however to always use

``js
socket.emit('todos::get', 1, {}, function(error, todo) {})

For SocketIO calls with at least an empty object as the parameters.

[Vitaliy-Yarovuy]

I apologize,
i find bug in my client code that's broke transfer more that two arguments to socket.emit
i use angural.js and write some service wrapper for socket.io client lib and there was bug

[daffl]

Ah ok, good to know. Also, if you are interested into open sourcing your Angular wrapper, I'd be happy to hear about it.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.