Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[authentication]: Support StackBlitz #3206

Closed
wants to merge 2 commits into from
Closed

Conversation

FossPrime
Copy link
Member

@FossPrime FossPrime commented Jun 3, 2023

  • On AuthenticationService.setup, The error suppression is necessary as without publish, you'll also get errors when login out.
  • disables validation and signing of JWT. This works surprisingly well... nothing is lost feature wise, aside from allowing others to spoof login, but that's not a concern in StackBlitz as WebContainers can't be hosted publicly. WASI runtimes run on bare metal and would not have an issue or be affected by this code.
  • performance impact is undetectable, as jwt.sign is a usertime function, and this boolean check is a computer time check of the fastest order.

P.S. I was working on a fine example for far too long, but the lack of ESM exports has ruined my day.
https://stackblitz.com/edit/feathersjs-playground-veesb9?file=vite.config.ts

@FossPrime FossPrime marked this pull request as ready for review June 5, 2023 05:13
@FossPrime FossPrime changed the title Supress error message for missing jwt in SB Support @feathersjs/authentication in StackBlitz Jun 5, 2023
@FossPrime FossPrime changed the title Support @feathersjs/authentication in StackBlitz Support StackBlitz (@feathersjs/authentication) Jun 5, 2023
@FossPrime FossPrime changed the title Support StackBlitz (@feathersjs/authentication) fix[authentication]: Support StackBlitz Jun 5, 2023
@FossPrime
Copy link
Member Author

Mitigated upstream

@FossPrime FossPrime closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant