Fix column types when default column is being patched for missing data features #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rc/main/scala/com/linkedin/feathr/offline/transformation/FeatureValueToColumnConverter.scala
Outdated
Show resolved
Hide resolved
feathr-impl/src/test/scala/com/linkedin/feathr/offline/AnchoredFeaturesIntegTest.scala
Show resolved
Hide resolved
feathr-impl/src/test/scala/com/linkedin/feathr/offline/AnchoredFeaturesIntegTest.scala
Outdated
Show resolved
Hide resolved
feathr-impl/src/test/scala/com/linkedin/feathr/offline/AnchoredFeaturesIntegTest.scala
Outdated
Show resolved
Hide resolved
| assertEquals(featureList(0).getAs[Row]("featureWithNull7"), null) | ||
| assertEquals(featureList(0).getAs[Row]("featureWithNull"),-1.0f) | ||
| assertEquals(featureList(0).getAs[Row]("featureWithNull4"),Map()) | ||
| assertEquals(featureList(0).getAs[Row]("featureWithNull4"), null) | ||
| assertEquals(featureList(0).getAs[Row]("featureWithNull2"),1.0f) | ||
| assertEquals(featureList(0).getAs[Row]("derived_featureWithNull"), |
There was a problem hiding this comment.
This test should have failed right? As derived_featureWithNull is computed from featureWithNull which itself is a NUMERIC type. Do we still expect the type of derived features from missed anchored features as
string -> float?
There was a problem hiding this comment.
My bad, the @test annotation was removed from this test, so the test was not being run.
There was a problem hiding this comment.
Actually, I still had this question, why is derived_featureWithNull a tensor when we know the type of featureWithNull is NUMERIC? Is the right expectation?
feathr-impl/src/test/scala/com/linkedin/feathr/offline/SlidingWindowAggIntegTest.scala
Show resolved
Hide resolved
feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala
Show resolved
Hide resolved
feathr-impl/src/main/scala/com/linkedin/feathr/offline/swa/SlidingWindowAggregationJoiner.scala
Show resolved
Hide resolved
...-impl/src/main/scala/com/linkedin/feathr/offline/join/workflow/AnchoredFeatureJoinStep.scala
Show resolved
Hide resolved
rakeshkashyap123
added
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix column types when default column is being patched for missing data features in both anchored and SWA features.