Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feathr UI: API spec alignment and ux experience improvement #303

Merged
merged 9 commits into from
Jun 2, 2022
Merged

Feathr UI: API spec alignment and ux experience improvement #303

merged 9 commits into from
Jun 2, 2022

Conversation

blrchen
Copy link
Collaborator

@blrchen blrchen commented May 27, 2022 •
edited
Loading

This PR update ui code to align with latest api spec which abstracts common interfaces among different registration providers. This PR also enhances lineage ux experience and adds RBAC experience for flighting.

Staging env: https://brave-moss-045d2ce00-6.eastasia.1.azurestaticapps.net/

New Feature registration API integration

API spec can be viewed at https://feathr-registry.azurewebsites.net/docs. UI code is now purview free.

UX improvements

  • When a feature is clicked, the feature node is highlighted
  • When a feature is clicked, the feature level lineage path is highlighted. Feature level lineage means direct producer and consumer.
  • Node in graph are colored grouped by feature type.
  • User can toggle graph to filter by feature type.
  • Flow arrow is enabled to indicate producer and consumer relationship
  • All out of scope resources are removed in graph, for example, Altas Process, Project.
  • Add navigate button in node so user can click to navigate to feature detail page.
  • RBAC in flgihting, accessible via /management path.

Linked issue: #272

@hangfei
Copy link
Collaborator

hangfei commented May 30, 2022

Overall it's pretty good. Some minor comments:

  1. After i clicked a certain figure, can we highlight the feature where i clicked?
  2. slightly move the graph in the middle.
  3. Add tooltip or explantion text for what each color means
  4. Add a way to click the feature and open the detail page.

hangfei
hangfei reviewed May 30, 2022
View reviewed changes
ui/package.json Show resolved Hide resolved
ui/src/api/api.tsx Outdated Show resolved Hide resolved
ui/src/app.tsx Outdated Show resolved Hide resolved
ui/src/app.tsx Outdated Show resolved Hide resolved
ui/src/components/lineage/graph.tsx Outdated Show resolved Hide resolved
ui/src/components/lineage/graph.tsx Outdated Show resolved Hide resolved
ui/src/components/lineage/graphNode.tsx Outdated Show resolved Hide resolved
ui/src/pages/feature/lineageGraph.tsx Outdated Show resolved Hide resolved
ui/src/pages/feature/lineageGraph.tsx Show resolved Hide resolved
ui/src/components/lineage/utils.ts Outdated Show resolved Hide resolved
hangfei
hangfei reviewed May 31, 2022
View reviewed changes
ui/src/api/api.tsx Outdated Show resolved Hide resolved
@blrchen blrchen changed the title Feathr UI: new lineage experience Feathr UI: API spec alignment and ux experience improvement Jun 1, 2022
@blrchen blrchen mentioned this pull request Jun 1, 2022
Merged
@windoze windoze mentioned this pull request Jun 1, 2022
Merged
@blrchen blrchen added the safe to test Tag to execute build pipeline for a PR from forked repo label Jun 1, 2022
hangfei
hangfei reviewed Jun 2, 2022
View reviewed changes
ui/src/models/model.ts Outdated Show resolved Hide resolved
ui/src/models/model.ts Show resolved Hide resolved
ui/src/models/model.ts Outdated Show resolved Hide resolved
@hangfei
Copy link
Collaborator

hangfei commented Jun 2, 2022 •
edited
Loading

Let's not put two distinct commits into one PR in the future. It's harder to review and ensure code quality. There is better way to avoid the problems you mentioned other than merging the commits into one PR. @Yuqing-cat @blrchen

@hangfei
Copy link
Collaborator

hangfei commented Jun 2, 2022

I can't really find the UI changes for RBAC. If it's not accessible from UI, please attach a screenshot.

@blrchen
Copy link
Collaborator Author

blrchen commented Jun 2, 2022

I can't really find the UI changes for RBAC. If it's not accessible from UI, please attach a screenshot.

RBAC UI is in flgihting, to pilot, plese use this direct url : https://brave-moss-045d2ce00-6.eastasia.1.azurestaticapps.net/management

@blrchen blrchen merged commit 91fb26f into feathr-ai:main Jun 2, 2022
@blrchen blrchen deleted the blairch/redesign-lineage branch June 2, 2022 05:05
bozhonghu pushed a commit that referenced this pull request Jun 2, 2022
@bobohu97
Merge branch 'main' into fcm_feathr_merge
9e35de7 
* main:
  added init py for import error (#308)
  add contribution text (#153)
  Add 'feathr hocon' command (#317)
  Feathr UI: API spec alignment and ux experience improvement (#303)
  bump version (#315)
  Adding custom data loader handler support. (#309)
  Update product_recommendation_demo.ipynb
  Update product_recommendation_demo.ipynb
  Product sample (#314)
  [Feathr] Add a example for product recommendation (#312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@hangfei hangfei hangfei approved these changes

@jaymo001 jaymo001 Awaiting requested review from jaymo001

@windoze windoze Awaiting requested review from windoze

@Yuqing-cat Yuqing-cat Awaiting requested review from Yuqing-cat

Assignees
No one assigned
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blrchen @hangfei @windoze @xiaoyongzhu @Yuqing-cat