Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added init py for import error in api folder #308

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

chinmaytredence
Copy link
Contributor

While trying to use feathr-project library, the following error was coming:
File "C:\Users\xyz\Documents\fethr_retail_dev_project_python\venv\lib\site-packages\feathr\anchor.py", line 2, in
from feathr.feature import Feature
File "C:\Users\xyz\Documents\fethr_retail_dev_project_python\venv\lib\site-packages\feathr\feature.py", line 7, in
from feathr.api.app.core.feathr_api_exception import FeatureNameValidationError
ModuleNotFoundError: No module named 'feathr.api'

@blrchen
Copy link
Collaborator

blrchen commented May 31, 2022

Hello @chinmaytredence thanks for contributing, we are holding changes on current REST API as new re-designed API is in progress. I will keep you updated when new API is ready for try.

@chinmaytredence
Copy link
Contributor Author

@blrchen Thanks for the update. For the time being I am using this PR commit to run the application which is using Feathr as the library. Would you like to give me the branch where the new API design is going on. Thanks.

@blrchen
Copy link
Collaborator

blrchen commented Jun 1, 2022

Hello, @chinmaytredence , following resources might be helpful for tracking latest api work status

@chinmaytredence
Copy link
Contributor Author

Thanks a lot @blrchen .

@hangfei
Copy link
Collaborator

hangfei commented Jun 2, 2022

@blrchen this is a simple and yet critical bug fix. I think we should get it in.

@xiaoyongzhu xiaoyongzhu reopened this Jun 2, 2022
@xiaoyzhuLI xiaoyzhuLI merged commit 7099607 into feathr-ai:main Jun 2, 2022
bozhonghu pushed a commit that referenced this pull request Jun 2, 2022
* main:
  added init py for import error (#308)
  add contribution text (#153)
  Add 'feathr hocon' command (#317)
  Feathr UI: API spec alignment and ux experience improvement (#303)
  bump version (#315)
  Adding custom data loader handler support. (#309)
  Update product_recommendation_demo.ipynb
  Update product_recommendation_demo.ipynb
  Product sample (#314)
  [Feathr] Add a example for product recommendation (#312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants