Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Control Plugin for Registry APIs #409

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

Yuqing-cat
Copy link
Collaborator

This PR covers

  • A access control plugin for all registry APIs (regardless of registry type)
  • Access Control Management APIs and management UI
  • A readme document

image

registry/api.py Outdated Show resolved Hide resolved
@Yuqing-cat
Copy link
Collaborator Author

Some updates:

  • Offer 2 options for @router.get("/features/{feature}":
    • if user pass project name, will validate access directly
    • if user do NOT pass project name, will validate access with the project name in feature response json
  • Clearer configuration
    • Add ".env" sample file
    • update os.envrion[""] to os.environ.get()
  • Add Exception for requests without token
  • The behavior of UI performs the same with test registry endpoint https://feathr-sql-registry.azurewebsites.net and localhost in all pages.

Will include in the following PR:

  • Add a redirect page for 403 Exceptions to tell user what access is required.

update sql query & enhance config
@Yuqing-cat
Copy link
Collaborator Author

Updates:

  • All SQL query is updated to prevent injection
  • All configs will follow the os.env >.env > default config sequence to get value.
  • All operation will read / write direct to SQL table rather than Cache.

@Yuqing-cat Yuqing-cat added the safe to test Tag to execute build pipeline for a PR from forked repo label Jul 4, 2022
@Yuqing-cat Yuqing-cat requested a review from blrchen July 4, 2022 07:43
@Yuqing-cat Yuqing-cat merged commit f8b5de7 into feathr-ai:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add azure ad authentication to Fast API Implement Basic RBAC Roles (Admin, Producer, Consumer)
3 participants