Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UDF documentation #454

Merged
merged 13 commits into from
Jul 18, 2022
Merged

Update UDF documentation #454

merged 13 commits into from
Jul 18, 2022

Conversation

xiaoyongzhu
Copy link
Member

@xiaoyongzhu xiaoyongzhu commented Jul 11, 2022

Since more and more users use Feathr UDFs, there are some limitations that wasn't documented very well, and this PR addresses this problem.

See the final doc rendering here: https://github.com/linkedin/feathr/blob/xiaoyzhu/udf_doc/docs/how-to-guides/feathr-udfs.md

@xiaoyongzhu xiaoyongzhu added the work-in-progress/do-not-merge Work in Progress PR, do not merge label Jul 11, 2022
@xiaoyongzhu xiaoyongzhu removed the work-in-progress/do-not-merge Work in Progress PR, do not merge label Jul 14, 2022
@xiaoyongzhu xiaoyongzhu changed the title Add UDF doc Update UDF documentation Jul 14, 2022
@xiaoyongzhu xiaoyongzhu requested review from jaymo001, Yuqing-cat, blrchen, hangfei, jainr and windoze and removed request for jaymo001 July 14, 2022 11:48
docs/concepts/feature-definition.md Show resolved Hide resolved
docs/concepts/feature-definition.md Show resolved Hide resolved
docs/how-to-guides/feathr-udfs.md Outdated Show resolved Hide resolved
docs/how-to-guides/feathr-udfs.md Outdated Show resolved Hide resolved
docs/how-to-guides/feathr-udfs.md Outdated Show resolved Hide resolved
Yuqing-cat
Yuqing-cat previously approved these changes Jul 15, 2022
Copy link
Collaborator

@Yuqing-cat Yuqing-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better if the wording UDF or UDFs aligned in the docs.

@xiaoyongzhu xiaoyongzhu merged commit 06c63ab into main Jul 18, 2022
@xiaoyongzhu xiaoyongzhu deleted the xiaoyzhu/udf_doc branch August 22, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants