Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some notes based on on-call issues #753

Merged
merged 3 commits into from
Oct 18, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/concepts/feature-registry.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ client.register_features()
all_features = client.list_registered_features(project_name=client.project_name)
```

Please avoid applying a same name to different features under a certain project. Since it will be treated as updating an exsiting project which is not supported by feathr and will cause errors.
xiaoyongzhu marked this conversation as resolved.
Show resolved Hide resolved

### Reuse Features from Existing Registry

The feature producers can just let the feature consumers know which features exist so the feature consumers can reuse them. For feature consumers, they can reuse existing features from the registry. The whole project can be retrieved to local environment by calling this API `client.get_features_from_registry` with a project name. This encourage feature reuse across organizations. For example, end users of a feature just need to read all feature definitions from the existing projects, then use a few features from the projects and join those features with a new dataset you have.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def __init__(self, synapse_dev_url: str, pool_name: str, datalake_dir: str, exec
# use the same credential for authentication to avoid further login.
self._api = _SynapseJobRunner(
synapse_dev_url, pool_name, executor_size=executor_size, executors=executors, credential=self.credential)
# Suggest to use an empty datalake directory for a new spark job to avoid errors.
xiaoyongzhu marked this conversation as resolved.
Show resolved Hide resolved
self._datalake = _DataLakeFiler(
datalake_dir, credential=self.credential)
# Save Synapse parameters to retrieve driver log
Expand Down