Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Display blunder bar in the winrate graph #384

Merged
merged 2 commits into from Nov 8, 2018

Conversation

@zsalch
Copy link
Collaborator

commented Oct 5, 2018

#351

I'm trying to display blunder bar in the winrate graph.

    1. Add new option 'show-winrate-blunder-bar' in the config.txt to turn on blunder bar, default is turn off.
    1. Can specify the minimum width of the blunder bar by the option 'minimum-winrate-blunder-bar-width' in the config.txt, default is 3.
    1. Considering that the winrate change should be mostly below 50%, an option is added to weighted display the height of the bar, that is, the change below 50% increases the display height, and the above 50% reduces the height. Currently only a simple weighted, the winrate change below 50% uses 75% of the display area, the above uses 25% of the display area. The default is off

turn off -> turn on
image
Adjusted for the green of the winrate graph should always be on top:
image

    1. Due to the small width of the winrate graph, when the move number is large, the display is crowded, so an option 'dynamic-winrate-graph-width' is added to dynamically adjust the width, so that can see clearly when the number of steps is small. Default is turn off.
    1. Add new option 'winrate-stroke-width' in the config.txt to set the winrate line width, default is 3.
    1. Add large winrate mode, press Ctrl+W to toggle:
      lb
@featurecat

This comment has been minimized.

Copy link
Owner

commented Oct 5, 2018

thanks. I think the green of the winrate graph should always be on top. is it possible to make it more visible? it's confusing in the middle of your graphs.

@featurecat

This comment has been minimized.

Copy link
Owner

commented Oct 5, 2018

also I absolutely love the name "blunder bar" 😁

@zsalch

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 6, 2018

I'm confuse too.
Need a solution to set the drawline and fillrect z-order.

@zsalch

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 6, 2018

Adjusted:
image

@OlivierBlanvillain OlivierBlanvillain force-pushed the zsalch:next_blunderbar branch 2 times, most recently from b24e815 to 843fc6f Oct 7, 2018

@zsalch zsalch referenced this pull request Oct 11, 2018

@zsalch zsalch force-pushed the zsalch:next_blunderbar branch from 958dced to fa530d7 Oct 25, 2018

@zsalch zsalch closed this Oct 30, 2018

@zsalch zsalch force-pushed the zsalch:next_blunderbar branch from fa530d7 to 9257fd3 Oct 30, 2018

@zsalch zsalch reopened this Oct 30, 2018

@zsalch zsalch requested a review from OlivierBlanvillain Oct 30, 2018

@zsalch zsalch force-pushed the zsalch:next_blunderbar branch from d878382 to c91bee0 Nov 3, 2018

@zsalch zsalch force-pushed the zsalch:next_blunderbar branch from 9be2eb1 to f40bc0e Nov 6, 2018

@featurecat

This comment has been minimized.

Copy link
Owner

commented Nov 7, 2018

Should I include this in Lizzie 0.6, and should I wait until you're done reviewing to do so?

@featurecat featurecat merged commit bcd4092 into featurecat:next Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.