Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: clearing state as well as adding get_state #876

Merged
merged 6 commits into from
Jun 17, 2023

Conversation

ahmadnazeri
Copy link
Contributor

@ahmadnazeri ahmadnazeri commented Jun 16, 2023

Description

Fixing ff.clear_state() as well as adding ff.get_state()

image

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri marked this pull request as ready for review June 16, 2023 23:33
@ahmadnazeri ahmadnazeri changed the title clearing state as well as adding get_state Bugfix: clearing state as well as adding get_state Jun 16, 2023
@ahmadnazeri ahmadnazeri changed the base branch from main to feature/ucb June 16, 2023 23:34
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 16, 2023 23:38 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feature/ucb@15ae948). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             feature/ucb     #876   +/-   ##
==============================================
  Coverage               ?   53.85%           
==============================================
  Files                  ?       67           
  Lines                  ?    13578           
  Branches               ?        0           
==============================================
  Hits                   ?     7312           
  Misses                 ?     5552           
  Partials               ?      714           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 16, 2023 23:46 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 16, 2023 23:46 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 16, 2023 23:46 — with GitHub Actions Inactive
Comment on lines +3395 to +3396

def __print_state(self, data):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __print_state(self, data):
def __print_state(self, data):
# TODO move out of register.py

@epps epps merged commit 6a29f43 into feature/ucb Jun 17, 2023
26 of 45 checks passed
@epps epps deleted the bugfix/clear_state_and_get_state branch June 17, 2023 00:08
simba-git pushed a commit that referenced this pull request Jun 17, 2023
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants