-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: clearing state as well as adding get_state #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadnazeri
changed the title
clearing state as well as adding get_state
Bugfix: clearing state as well as adding get_state
Jun 16, 2023
sdreyer
approved these changes
Jun 16, 2023
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:38
— with
GitHub Actions
Error
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:38
— with
GitHub Actions
Error
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:38
— with
GitHub Actions
Failure
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:38
— with
GitHub Actions
Error
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:38
— with
GitHub Actions
Error
ahmadnazeri
temporarily deployed
to
Integration testing
June 16, 2023 23:38
— with
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## feature/ucb #876 +/- ##
==============================================
Coverage ? 53.85%
==============================================
Files ? 67
Lines ? 13578
Branches ? 0
==============================================
Hits ? 7312
Misses ? 5552
Partials ? 714 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anthonylasso
approved these changes
Jun 16, 2023
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:42
— with
GitHub Actions
Error
sdreyer
approved these changes
Jun 16, 2023
ahmadnazeri
temporarily deployed
to
Integration testing
June 16, 2023 23:46
— with
GitHub Actions
Inactive
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:46
— with
GitHub Actions
Failure
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:46
— with
GitHub Actions
Failure
ahmadnazeri
temporarily deployed
to
Integration testing
June 16, 2023 23:46
— with
GitHub Actions
Inactive
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:46
— with
GitHub Actions
Failure
ahmadnazeri
temporarily deployed
to
Integration testing
June 16, 2023 23:46
— with
GitHub Actions
Inactive
ahmadnazeri
had a problem deploying
to
Integration testing
June 16, 2023 23:49
— with
GitHub Actions
Failure
aolfat
reviewed
Jun 17, 2023
Comment on lines
+3395
to
+3396
|
||
def __print_state(self, data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
def __print_state(self, data): | |
def __print_state(self, data): | |
# TODO move out of register.py |
simba-git
pushed a commit
that referenced
this pull request
Jun 17, 2023
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing
ff.clear_state()
as well as addingff.get_state()
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: