Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Tag Updates #907

Merged
merged 44 commits into from
Jul 8, 2023
Merged

Resource Tag Updates #907

merged 44 commits into from
Jul 8, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Jul 5, 2023

Description

This PR allows the creation and updates for resources tags in the dashboard.
Each resource variant has it's own separate set of tags.

It includes POST endpoints in the metadata layer, and chip functionality in the FE.

example

Screen.Recording.2023-07-06.at.4.58.33.PM.mov

Unit Tests:
FE
Screenshot 2023-07-06 at 4 19 49 PM

BE
Screenshot 2023-07-05 at 3 30 33 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #907 (df88342) into main (dadd2e0) will increase coverage by 7.71%.
The diff coverage is 55.85%.

@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   51.20%   58.92%   +7.71%     
==========================================
  Files          67       67              
  Lines       13578    13595      +17     
==========================================
+ Hits         6953     8011    +1058     
+ Misses       5972     4780    -1192     
- Partials      653      804     +151     
Impacted Files Coverage Δ
provider/k8s.go 26.88% <0.00%> (+24.80%) ⬆️
metadata/metadata.go 71.18% <69.23%> (+0.27%) ⬆️
metadata/etcd.go 64.30% <89.65%> (ø)
metadata/client.go 84.45% <100.00%> (+0.09%) ⬆️
metadata/updates.go 92.50% <100.00%> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso temporarily deployed to Integration testing July 5, 2023 20:45 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 5, 2023 20:45 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 5, 2023 20:45 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 5, 2023 20:45 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 5, 2023 20:45 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 7, 2023 23:45 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 7, 2023 23:45 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 02:26 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 02:26 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 02:26 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 02:26 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 02:26 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 03:32 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 03:32 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 03:32 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 03:32 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 03:32 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 03:32 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 18:13 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 18:13 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 18:13 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 18:13 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 18:13 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 9826a50 into main Jul 8, 2023
42 of 45 checks passed
@anthonylasso anthonylasso deleted the feature/tagUpdate branch July 8, 2023 20:36
@anthonylasso anthonylasso mentioned this pull request Aug 17, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants