Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ETCD issue #945 #967

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix ETCD issue #945 #967

merged 1 commit into from
Aug 17, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Aug 17, 2023

Description

Fix for issue #945

Issue is related to update tags pull request.

running standalone docker
Screenshot 2023-08-17 at 4 42 42 PM

build + run command output
docker build + run success.txt

Solves a misconfiguration that I placed into the etcd server config during the tags update pull request. The value featureform-etcd is only used in hosted mode, and instead should be localhost for standalone docker mode.

#945

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing August 17, 2023 21:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 17, 2023 21:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 17, 2023 21:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 17, 2023 21:05 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 17, 2023 21:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #967 (70ae2ee) into main (00de8c6) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   59.15%   58.92%   -0.23%     
==========================================
  Files         107      107              
  Lines       19194    19194              
==========================================
- Hits        11354    11311      -43     
- Misses       7068     7110      +42     
- Partials      772      773       +1     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso marked this pull request as ready for review August 17, 2023 21:56
@ahmadnazeri ahmadnazeri self-requested a review August 17, 2023 21:59
@anthonylasso anthonylasso merged commit 78aad82 into main Aug 17, 2023
47 of 49 checks passed
@anthonylasso anthonylasso deleted the bugfix/etcd/82 branch August 17, 2023 22:15
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants