Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHook URL can't be HTTPS #1115

Closed
1 of 5 tasks
TheSylence opened this issue Jan 26, 2024 · 3 comments · Fixed by #1116
Closed
1 of 5 tasks

WebHook URL can't be HTTPS #1115

TheSylence opened this issue Jan 26, 2024 · 3 comments · Fixed by #1116

Comments

@TheSylence
Copy link

Describe the bug
HTTPS Urls can't be used as Webhook URL because "Please enter a valid URL".

Which area does this issue belong to?

  • FeatureHub Admin Web app
  • SDK
  • SDK examples
  • Documentation
  • Other

To Reproduce

  1. Go to Webhook Configuration
  2. Enter https://localhost as Webhook URL
  3. Validation fails with "Please enter a valid URL" and configuration can't be saved
  4. http://localhost validates and can be saved

Expected behavior
HTTPS Urls can be used as a webhook URL.

Versions

  • FeatureHub version 1.7.2-RC
@IrinaSouth
Copy link
Contributor

Hi there,
Thanks for reporting this, we will add a fix for this asap.

IrinaSouth pushed a commit that referenced this issue Jan 28, 2024
fix #1115
6a2ebec 
plus other integration fixes for Slack (future release)
@IrinaSouth IrinaSouth linked a pull request Jan 28, 2024 that will close this issue
Fix for #1115 - webhook url to allow https #1116
Merged
rvowles pushed a commit that referenced this issue Jan 29, 2024
@IrinaSouth
fix #1115 (#1116)
57502ce 
plus other integration fixes for Slack (future release)

Co-authored-by: Irina Southwell <“irinasouthwell@gmail.com”>
@IrinaSouth
Copy link
Contributor

IrinaSouth commented Jan 29, 2024 •
edited

Fix is released in 1.7.2-RC @TheSylence

@rvowles
Copy link
Contributor

rvowles commented Jan 29, 2024

This was back-ported to the 1.7.1 current release - so those images have been refreshed with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #1115 - webhook url to allow https featurehub-io/featurehub
3 participants
@rvowles @TheSylence @IrinaSouth