Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use s3 demo csv with better column names #139

Merged
merged 2 commits into from
May 7, 2018
Merged

Conversation

Seth-Rothschild
Copy link
Contributor

Change the location from which we download the demo retail data. With that, we can remove the line which replaced the old column names.

@codecov-io
Copy link

Codecov Report

Merging #139 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   90.73%   90.73%   -0.01%     
==========================================
  Files          76       76              
  Lines        7824     7823       -1     
==========================================
- Hits         7099     7098       -1     
  Misses        725      725
Impacted Files Coverage Δ
featuretools/demo/retail.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f48c9...9a30615. Read the comment docs.

@kmax12
Copy link
Contributor

kmax12 commented May 7, 2018

Looks good merging

@kmax12 kmax12 merged commit 86a978c into master May 7, 2018
@Seth-Rothschild Seth-Rothschild deleted the update-demo-retail branch May 8, 2018 03:58
@rwedge rwedge mentioned this pull request May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants