New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling time rewrite #245

Merged
merged 17 commits into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Sep 5, 2018

close #244

  • Add a substantial section on what time_index means (with retail example)
  • Add a section for secondary_time_index with the flight example
  • Add example with same index but multiple time indices
  • Emphasize that cutoff times are an instruction list and limit the row output
  • Emphasize the ways that time is used in building features
  • Merge Training Window and Last Time Index sections/examples
  • Add approximate paragraph from elsewhere in docs
  • Add visuals which show how we use time

Draft available here as html:
handling_time9-24.zip
(updated 9/24 12:03)

@codecov-io

This comment has been minimized.

codecov-io commented Sep 5, 2018

Codecov Report

Merging #245 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   94.45%   94.46%   +<.01%     
==========================================
  Files          71       71              
  Lines        7670     7676       +6     
==========================================
+ Hits         7245     7251       +6     
  Misses        425      425
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.28% <100%> (ø) ⬆️
featuretools/demo/mock_customer.py 95.45% <100%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3db946...9c3d4be. Read the comment docs.

@Seth-Rothschild Seth-Rothschild changed the title from (WIP) Handling time rewrite to Handling time rewrite Sep 13, 2018

@Seth-Rothschild Seth-Rothschild force-pushed the handling-time-rewrite branch from 8521ed2 to 0cf389f Sep 24, 2018

Seth-Rothschild added some commits Sep 24, 2018

@Seth-Rothschild

This comment has been minimized.

Contributor

Seth-Rothschild commented Sep 25, 2018

@kveerama @kmax12 this should be good to go

Seth-Rothschild and others added some commits Sep 28, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented Sep 28, 2018

Looks good merging

@kmax12 kmax12 merged commit a891895 into master Sep 28, 2018

1 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 referenced this pull request Sep 28, 2018

Merged

v0.3.1 #270

@kmax12 kmax12 deleted the handling-time-rewrite branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment