New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding progress_callback parameter to dfs() and calculate_feature_matrix(), removing time remaining #739
Conversation
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 97.66% 97.69% +0.03%
==========================================
Files 118 118
Lines 10289 10340 +51
==========================================
+ Hits 10049 10102 +53
+ Misses 240 238 -2
Continue to review full report at Codecov.
|
featuretools/computational_backends/calculate_feature_matrix.py
Outdated
Show resolved
Hide resolved
featuretools/computational_backends/calculate_feature_matrix.py
Outdated
Show resolved
Hide resolved
featuretools/computational_backends/calculate_feature_matrix.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Go ahead and merge
Addresses #705 and #736 by adding
progress_callback
parameter todfs()
andcalculate_feature_matrix(
) and removing time remaining field from the progress bar inverbose=True
mode.