docs: updated next js docs to include app router example #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahad19
reviewed
Feb 28, 2024
docs/frameworks/nextjs.md
Outdated
| @@ -149,7 +149,29 @@ See documentation about `bucketBy` property in feature definitions for further e | |||
|
|
|||
| ## App Router | |||
|
|
|||
| We do not have documentation for Featurevisor SDK usage with Next.js App Router yet. If you are interested in contributing, please reach out to us on [GitHub](https://github.com/featurevisor/featurevisor). | |||
| If your using app router, you can use like this | |||
There was a problem hiding this comment.
We can change it to something like this:
"If you are using App Router, you can do something like this:"
fahad19
reviewed
Feb 28, 2024
docs/frameworks/nextjs.md
Outdated
| // src/app/approuter/page.tsx | ||
| import { getInstance } from "../../featurevisor"; | ||
|
|
||
| export default function Home() { |
There was a problem hiding this comment.
should it be an async component?
like here? https://github.com/featurevisor/featurevisor-example-nextjs/blob/main/src/app/approuter/page.tsx#L5
|
fahad19
approved these changes
Mar 5, 2024
fahad19
added a commit
that referenced
this pull request
Mar 10, 2024
* main: docs: Fastify integration (#270) docs: add Roku SDK documentation (#272) docs: fix code block v1.11.0 feat: revisioning info moved to its own file (#274) v1.10.1 fix: init command (#277) v1.10.0 feat: allow showing only failed specs in test runner (#276) v1.9.0 feat: allow printing datafile per environment (#275) docs: updated next js docs to include app router example (#268) v1.8.0 feat: allow option to test by generating datafiles early (#267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated next js docs for app router https://github.com/featurevisor/featurevisor-example-nextjs/blob/main/src/app/approuter/page.tsx