-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fastify integration #270
Conversation
of returning strings
docs/frameworks/fastify.md
Outdated
|
||
## Decorator | ||
|
||
If is very unlikely that we will have all our routes defined in the same index.js file, making it difficult for us to use the same Featurevisor SDK instance in all of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
docs/frameworks/fastify.md
Outdated
const featureKey = "my_feature"; | ||
const context = { userId: "123", country: "nl" }; | ||
|
||
const isEnabled = f.isEnabled(featureKey, context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we extract f
out of request
first inside this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed to import it from request. instead of defining in function because it is already defined in the outer scope
Ref: https://github.com/jagadeeshgade008/featurevisor-example-fastify/blob/main/index.js
@fahad19 Can you verify now |
@jagadeeshgade008: I have created this empty repo https://github.com/featurevisor/featurevisor-example-fastify you can send a PR for your example, and I will merge it first before merging the docs and publishing the site. |
@fahad19 |
@jagadeeshgade008: empty file created. you should be able to send a PR now. |
thanks so much, @jagadeeshgade008! page is available here now: https://featurevisor.com/docs/frameworks/fastify/ |
* main: docs: Fastify integration (#270) docs: add Roku SDK documentation (#272) docs: fix code block v1.11.0 feat: revisioning info moved to its own file (#274) v1.10.1 fix: init command (#277) v1.10.0 feat: allow showing only failed specs in test runner (#276) v1.9.0 feat: allow printing datafile per environment (#275) docs: updated next js docs to include app router example (#268) v1.8.0 feat: allow option to test by generating datafiles early (#267)
Fastify example repo is not available yet. I'll add it once it's up. Meanwhile, check out this complete working app https://github.com/jagadeeshgade008/featurevisor-example-fastify.