-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyperx #68
Comments
i'm not 100% sure, just because we need to keep hyperdom up to date with the latest hyperx releases, or peer dependency..? But to be honest, this is not hard to do: var hx = require('hyperx')(require('hyperdom').jsx) perhaps we just need some docs for it? |
I was thinking just having hyperx as a runtime dependency so it wouldn't even exist in hyperdom/package.json then in hyperdom wrap it in a try catch and throw an error saying you need to install hyperx to use this - just like we do in sworm. I guess it would be this simple: try {
module.exports = require('hyperx')(require('hyperdom').jsx)
}
catch {
throw new Error('to use hyperx with hyperdom you need to install the hyperx package')
} |
Ok sounds good!
Derek Ekins <notifications@github.com> schrieb am Mo. 20. März 2017 um
08:49:
… I was thinking just having hyperx as a runtime dependency so it wouldn't
even exist in hyperdom/package.json
then in hyperdom wrap it in a try catch and throw an error saying you need
to install hyperx to use this - just like we do in sworm.
I guess it would be this simple:
try {
module.exports = require('hyperx')(require('hyperdom').jsx)
}catch {
throw new Error('to use hyperx with hyperdom you need to install the hyperx package')
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHkDf_7TjNxkNqKZidKCxfh5jgGDl9aks5rnj1_gaJpZM4MbZzi>
.
|
👍🏻 |
Is there some runtime performance penalty for hyperx? Or any way to rewrite hyperx into function calls like we do with jsx? |
Yes you can hyperxify it of course :-)
https://www.npmjs.com/package/hyperxify
…On 20 March 2017 at 09:48, Josh Chisholm ***@***.***> wrote:
Is there some runtime performance penalty for hyperx? Or any way to
rewrite hyperx into function calls like we do with jsx?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI2GuITYV8plQWEaC34pjhy3AHwP-peks5rnktUgaJpZM4MbZzi>
.
|
see #73 for implementation |
it would be cool if hyperdom had integration with hyperx so you could do something like this:
The text was updated successfully, but these errors were encountered: