Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mssql driver to version 4 #42

Open
navarroaxel opened this issue Apr 13, 2018 · 3 comments
Open

Upgrade mssql driver to version 4 #42

navarroaxel opened this issue Apr 13, 2018 · 3 comments

Comments

@navarroaxel
Copy link

Upgrade to the latest mssql package version 4.1.0.

Version 4 contains breaking changes https://github.com/tediousjs/node-mssql#3x-to-4x-changes
@dereke
Copy link
Member

dereke commented Apr 16, 2018

this sounds like a good idea.

also @refractalize we might be able to run tests against MSSQL in CI using this https://hub.docker.com/r/microsoft/mssql-server-linux/

@cameronstubber
Copy link

Also now hitting this issue.

@Naturious
Copy link
Contributor

I attacked the issue, looked through everything, and it seems changing Connection to ConnectionPool in mssqlDriver.js is enough. It seems someone else has tried a PR with that change and it couldn't go through because of travis-ci. Can someone walk me through how I should build this with travis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dereke @navarroaxel @Naturious @cameronstubber