This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Restore paging and sorting. #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both the data tables and the tabbing interface can change the window history, the data tables should only refresh on popState when the relevant query parameters have changed. Previously, this check was applied on every table reload; this patch applies the check only on reloads triggered by the popState event. [Resolves fecgov#433]
noahmanger
pushed a commit
that referenced
this pull request
Aug 6, 2015
Restore paging and sorting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since both the data tables and the tabbing interface can change the
window history, the data tables should only refresh on popState when the
relevant query parameters have changed. Previously, this check was
applied on every table reload; this patch applies the check only on
reloads triggered by the popState event.
[Resolves #433]