Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css-to-inline-styles to v2.1 #38

Merged
merged 2 commits into from
Sep 19, 2016
Merged

Conversation

Belphemur
Copy link
Contributor

Update the test, remove the configuration that are not used anymore
Add config to set CSS files to be use directly in emails

Update the test, remove the configuration that are not used anymore
Add config to set CSS files to be use directly in emails
@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Coverage decreased (-5.4%) to 62.857% when pulling e763ee2 on Belphemur:master into e1869cb on fedeisas:master.

@ceesvanegmond
Copy link
Contributor

@Belphemur Thank you for the addition! Why doesn't it pass on HHVM? Could you fix that?

@Belphemur
Copy link
Contributor Author

It's the library itself, not the code here.

@tijsverkoyen has put HHVM as allow_failure on his test for now. You can see it here in the last build: https://travis-ci.org/tijsverkoyen/CssToInlineStyles/jobs/160315806

I can't do anything about this other than also asking travis to allow the failure.

@ceesvanegmond
Copy link
Contributor

@Belphemur Could you add the

  allow_failures:
    - php: hhvm

to this merge request too?

@Belphemur
Copy link
Contributor Author

@ceesvanegmond added 👍

@coveralls
Copy link

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-5.4%) to 62.857% when pulling e84dff0 on Belphemur:master into e1869cb on fedeisas:master.

@ceesvanegmond ceesvanegmond merged commit c58e663 into fedeisas:master Sep 19, 2016
@ceesvanegmond
Copy link
Contributor

@Belphemur Thx!

@ceesvanegmond
Copy link
Contributor

@Belphemur Is this fully backwards compatible? Should we tag it on v1.6?

@Belphemur
Copy link
Contributor Author

Belphemur commented Sep 19, 2016

I would bump the major version since the behavior of the underlying lib also changed. It doesn't strip the style tag anymore.

Moreover the default config changed to add the possibility to set the css files and removed the other options.

Sent from BlueMail

On Sep 19, 2016, 16:42, at 16:42, Cees van Egmond notifications@github.com wrote:

@Belphemur Is this fully backwards compatible? Should we tag it on
v1.6?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#38 (comment)

@ceesvanegmond
Copy link
Contributor

@Belphemur
Copy link
Contributor Author

@ceesvanegmond Cheers!

Thanks for the quick update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants