-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update css-to-inline-styles to v2.1 #38
Conversation
Update the test, remove the configuration that are not used anymore Add config to set CSS files to be use directly in emails
@Belphemur Thank you for the addition! Why doesn't it pass on HHVM? Could you fix that? |
It's the library itself, not the code here. @tijsverkoyen has put HHVM as allow_failure on his test for now. You can see it here in the last build: https://travis-ci.org/tijsverkoyen/CssToInlineStyles/jobs/160315806 I can't do anything about this other than also asking travis to allow the failure. |
@Belphemur Could you add the allow_failures:
- php: hhvm to this merge request too? |
@ceesvanegmond added 👍 |
@Belphemur Thx! |
@Belphemur Is this fully backwards compatible? Should we tag it on v1.6? |
I would bump the major version since the behavior of the underlying lib also changed. It doesn't strip the style tag anymore. Moreover the default config changed to add the possibility to set the css files and removed the other options. Sent from BlueMail On Sep 19, 2016, 16:42, at 16:42, Cees van Egmond notifications@github.com wrote:
|
@Belphemur Right! Check it out! |
@ceesvanegmond Cheers! Thanks for the quick update. |
Update the test, remove the configuration that are not used anymore
Add config to set CSS files to be use directly in emails