Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to afterResolving when registering service provider #90

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

TheoGibbons
Copy link
Contributor

This helps fix the conflict with therobfonz/laravel-mandrill-driver on Laravel 7.
They will also need to fix their ServiceProvider before the conflict is fully resolved.
#84

@juukie
Copy link
Contributor

juukie commented Jun 16, 2020

Thanks @TheoGibbons. Hopefully @fedeisas will be able to merge and tag soon.

@lbeauvisage
Copy link

Thank you so much @TheoGibbons , it also fix the problem form vemcogroup/laravel-sparkpost-driver and probably s-ichikawa/laravel-sendgrid-driver

With Laravel 7 it cause the error

InvalidArgumentException
Unsupported mail transport [sparkpost].

@fedeisas fedeisas merged commit 7843a62 into fedeisas:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants