fix: calculate the batches per sessions correctly to achieve fault tolerance #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can validate it using https://github.com/Maan2003/fedimint/commits/consensus-test-old ./scripts/tests/consensus-fix.sh /path/to/old-fedimintd |
|
How are we going to test this change works as intended? I would like to see a test where a 3/4 federation with 1 guardian offline produces a session. #4198 may help with this. |
elsirion
approved these changes
Feb 1, 2024
| // indefinitely. Hence we increase the delay between rounds exponentially | ||
| // such that MAX_ROUND would only be reached after roughly 350 years. | ||
| // indefinitely. Hence, we increase the delay between rounds exponentially | ||
| // such that max_round would only be reached after a minimum of 100 years. |
There was a problem hiding this comment.
That is enforced by AlephBFT on startup, right?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
fix: calculate the batches per sessions correctly to achieve fault tolerance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4188 +/- ##
==========================================
- Coverage 58.17% 57.90% -0.28%
==========================================
Files 192 197 +5
Lines 43225 43416 +191
==========================================
- Hits 25145 25138 -7
- Misses 18080 18278 +198 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
We really need to fix CI 😭 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.