Run devimint and rust tests with 1/4 guardians offline #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmoon
force-pushed
the
degrade-everything
branch
from
7c30cf4
to
66d0c28
Compare
justinmoon
commented
Feb 1, 2024
|
|
||
| /// Run federation with 1/4 guardians offline | ||
| #[arg(long, env = "FM_DEVIMINT_DEGRADED")] | ||
| pub degraded: bool, |
There was a problem hiding this comment.
I stuck this on the "common" arguments so I didn't have copy/paste this for every test command ...
justinmoon
force-pushed
the
degrade-everything
branch
from
66d0c28
to
1b799ac
Compare
justinmoon
commented
Feb 1, 2024
scripts/tests/test-ci-all.sh
Outdated
| @@ -5,6 +5,9 @@ set -euo pipefail | |||
| # prevent locale settings messing with some setups | |||
| export LANG=C | |||
|
|
|||
| # run with 1 guardian offline | |||
| export FM_DEVIMINT_DEGRADED=1 | |||
There was a problem hiding this comment.
This just sets a default to run all these tests with 1 guardians offline. I'm not sure what's best to do here.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4198 +/- ##
==========================================
- Coverage 57.95% 57.94% -0.02%
==========================================
Files 197 197
Lines 43413 43429 +16
==========================================
+ Hits 25161 25163 +2
- Misses 18252 18266 +14 ☔ View full report in Codecov by Sentry. |
justinmoon
force-pushed
the
degrade-everything
branch
from
1b799ac
to
fc772e5
Compare
douglaz
reviewed
Feb 1, 2024
| @@ -102,6 +104,9 @@ impl FederationTest { | |||
|
|
|||
| let mut task = TaskGroup::new(); | |||
| for (peer_id, config) in configs.clone() { | |||
| if (u16::from(peer_id)) >= num_online { | |||
There was a problem hiding this comment.
Suggested change
| if (u16::from(peer_id)) >= num_online { | |
| if u16::from(peer_id) >= num_online { |
This runs them with 1/4 guardians offline
This probably isn't the right thing to do here. Mostly just trying to see what happens in CI ...
justinmoon
force-pushed
the
degrade-everything
branch
from
6fb3428
to
11dfaf5
Compare
|
I think @bradleystachurski took this over in #4247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FM_DEVIMINT_DEGRADEDenvironment variable.FederationTestfixture to start with 1 guardian offlineFederationTestsso we can try any valid federation size and number of online / offline guardians. But I didn't attempt this here.