Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: justfile uses import instead of \!include #4228

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

elsirion
Copy link
Contributor

@elsirion elsirion commented Feb 3, 2024

With the latest nixpkgs update we apparently got a new just version that errors with our justfile:

$ just mprocs
error: The `!include` directive has been stabilized as `import`
 ——▶ justfile:2:1
  │
2 │ !include justfile.fedimint.just
  │ ^

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3483323) 57.94% compared to head (8933aaa) 57.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4228   +/-   ##
=======================================
  Coverage   57.94%   57.94%           
=======================================
  Files         197      197           
  Lines       43413    43413           
=======================================
  Hits        25156    25156           
  Misses      18257    18257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion elsirion marked this pull request as ready for review February 4, 2024 06:27
@elsirion elsirion requested a review from a team as a code owner February 4, 2024 06:27
@elsirion elsirion requested review from dpc and maan2003 February 4, 2024 06:27
@dpc
Copy link
Contributor

dpc commented Feb 4, 2024

Good workaround. I'll need to fix it in flakebox.

@maan2003 maan2003 added this pull request to the merge queue Feb 4, 2024
Merged via the queue into fedimint:master with commit 32bac95 Feb 4, 2024
22 checks passed
@elsirion elsirion deleted the 2024-02-justfix branch February 4, 2024 10:01
dpc added a commit to dpc/fedimint that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants