Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update flakebox to remove a workaround #4245

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Feb 5, 2024

Re (workaround): #4228

@dpc dpc requested review from a team as code owners February 5, 2024 19:34
@dpc dpc enabled auto-merge February 5, 2024 19:34
@dpc dpc disabled auto-merge February 6, 2024 04:23
@dpc dpc enabled auto-merge February 6, 2024 04:23
@dpc dpc disabled auto-merge February 6, 2024 04:23
@dpc dpc enabled auto-merge February 6, 2024 04:23
@dpc dpc added this pull request to the merge queue Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (6f1176e) 57.87% compared to head (3308799) 57.99%.
Report is 7 commits behind head on master.

Files Patch % Lines
fedimint-cli/src/client.rs 0.00% 16 Missing ⚠️
fedimint-client/src/module/mod.rs 0.00% 13 Missing ⚠️
modules/fedimint-mint-client/src/lib.rs 96.18% 5 Missing ⚠️
fedimint-load-test-tool/src/common.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4245      +/-   ##
==========================================
+ Coverage   57.87%   57.99%   +0.12%     
==========================================
  Files         197      197              
  Lines       43420    43569     +149     
==========================================
+ Hits        25129    25270     +141     
- Misses      18291    18299       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into fedimint:master with commit 93c18ad Feb 6, 2024
22 checks passed
@dpc dpc deleted the 24-02-05-workaround-fix branch February 6, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants