Remove FederationInfo #4297
Remove FederationInfo #4297
Conversation
There was a problem hiding this comment.
The whole point of this struct is to allow 3rd party integrators to gather some basic information about the federation to show to users before joining. I guess we could try to merge its functionality with the ClientConfig type now that we can generate InviteCodes from config again (that wasn't possible when this type was created).
|
I think porting the functionality to the client config makes sense as FederationInfo is practically only a wrapper around the config since we can generate invite codes from the client config. What functionality would you like to see ported? |
|
The whole public interface except |
joschisan
force-pushed
the
rm_fed_info
branch
2 times, most recently
from
b51d334
to
a7a18f4
Compare
joschisan
force-pushed
the
rm_fed_info
branch
4 times, most recently
from
5012799
to
849fa63
Compare
fedimint-client/src/lib.rs
Outdated
| @@ -2214,29 +2159,66 @@ pub async fn get_invite_code_from_db(db: &Database) -> Option<InviteCode> { | |||
|
|
|||
| /// Tries to download the client config from the federation, | |||
| /// attempts up to `retries` number times | |||
There was a problem hiding this comment.
retries isn't an argument anymore.
fedimint-client/src/lib.rs
Outdated
| invite_code: InviteCode, | ||
| max_retries: usize, | ||
| ) -> anyhow::Result<ClientConfig> { | ||
| pub async fn download_client_config(invite_code: &InviteCode) -> anyhow::Result<ClientConfig> { |
There was a problem hiding this comment.
Can we make this a constructor/member of ClientConfig to replicate the FederationInfo interface. I.e. the user should be able to call ClientConfig::download_with_invite(invite) or something similar.
| DynGlobalApi::from_config(self) | ||
| } | ||
|
|
||
| pub fn invite_code(&self, peer: &PeerId) -> Option<InviteCode> { |
There was a problem hiding this comment.
Documentation needed: what does the peer argument do?
joschisan
force-pushed
the
rm_fed_info
branch
from
849fa63
to
53a8849
Compare
| } | ||
|
|
||
| /// Tries to download the client config from the federation, | ||
| /// attempts to retry teb times before giving up. |
There was a problem hiding this comment.
still relevant, but whatever …
|
Needs rebase, feel free to request review from others in the future when I'm out :) |
joschisan
force-pushed
the
rm_fed_info
branch
from
53a8849
to
eb9a381
Compare
| } | ||
|
|
||
| /// Tries to download the client config from the federation, | ||
| /// attempts to retry teb times before giving up. |
There was a problem hiding this comment.
still relevant, but whatever …
|
Might be worth incorporating #4371 into this PR too or a follow-up. |
Many methods were never used, the invite_code field was never read. Every time this struct was created from an invite code the caller just wanted to obtain the client config.