feat: generate essential num guardians InviteCode #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernelkind
force-pushed
the
issue-4306
branch
from
cc8f745
to
b7d9457
Compare
|
I don't think the build pipeline fail is valid, can we re-run it? |
elsirion
reviewed
Feb 21, 2024
kernelkind
force-pushed
the
issue-4306
branch
from
b7d9457
to
41411c6
Compare
kernelkind
changed the title
elsirion
reviewed
Feb 21, 2024
kernelkind
force-pushed
the
issue-4306
branch
from
41411c6
to
0777fd6
Compare
The option is now available to generate an InviteCode with max_evil + 1 number of guardian urls in case some guardians go offline. Closes: fedimint#4306
kernelkind
force-pushed
the
issue-4306
branch
from
0777fd6
to
99fd9f8
Compare
elsirion
approved these changes
Feb 22, 2024
m1sterc001guy
approved these changes
Feb 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Nice PR @kernelkind! Thanks for contributing. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is now available to generate an InviteCode with max_evil + 1 number of guardian urls in case some guardians go offline.
Closes: #4306