fix: run real fedimint-ln-gateway tests

[bradleystachurski]

🙈

[justinmoon]

So was this a no-op?

[bradleystachurski]

Correct 👍

[bradleystachurski]

Hmm, odd this passed the PR CI but failed the merge queue

104719   │ 2024-02-22T14:07:40.2486496Z 00:05:48      Summary [  72.254s] 8/20 tests run: 7 passed, 1 failed, 0 skipped
104720   │ 2024-02-22T14:07:40.2486964Z 00:05:48         FAIL [  33.834s] fedimint-ln-gateway::gatewayd-integration-tests test_gateway_can_pay_ldk_node

More details

104635   │ 2024-02-22T14:07:40.2444588Z 00:05:21 thread 'test_gateway_can_pay_ldk_node' panicked at gateway/ln-gateway/tests/integration_tests.rs:187:13:
104636   │ 2024-02-22T14:07:40.2447898Z 00:05:21 assertion failed: `Canceled { error: OutgoingPaymentError { error_type: LightningPayError { lightning_error: FailedPayment { fail
        │ ure_reason: "FailureReasonNoRoute" } }, contract_id: bec4bb4907c5469edc8453946401ff15c6d5c80f3429967cb0662cb75dd24644, contract: Some(OutgoingContractAccount { amount:
        │  Amount { msats: 250000 }, contract: OutgoingContract { hash: e569bd88a54133c2b6901afaced1ebc4377e6969a11fff0fa93a80974f474363, gateway_key: PublicKey(18fde48e4acba6f4
        │ 0e1e6c70eaefd04c8f716ee50117968b81c5a91797ea875c1b3354bc00f8739085e4b4a8a9628dfa7b5eefd77ef063e4de0e8d32fb34870c), timelock: 758, user_key: PublicKey(25322123f8cdef54e
        │ 64ed7b5e6e7d438df45fdf4077284b0b0dd5d9661e7c51a267409a4fdd48931956c69cc9a705d84c305c4f593cbaf4ee3db3101501195bf), cancelled: false } }) } }` does not match `GatewayExt
        │ PayStates::Preimage { .. }`

[bradleystachurski]

Yeah, this is a flakey test. Passed the 1x test but failed the 5x in merge queue.

79736   │ 2024-02-22T15:23:31.7562175Z fedimint-test-all-ci> 00:05:34      Summary [  71.880s] 8/20 tests run: 7 passed, 1 failed, 0 skipped
79737   │ 2024-02-22T15:23:31.7562655Z fedimint-test-all-ci> 00:05:34         FAIL [  33.647s] fedimint-ln-gateway::gatewayd-integration-tests test_gateway_can_pay_ldk_node

I'm going to disable that test

• We'll hopefully resolve with chore: upgrade to ldk-node 0.2.1 #4354
• We're still in an overall better spot with the rest of the ln-gateway tests running against real nodes

[elsirion]

Fiat CI strikes again 🙈

[bradleystachurski]

@elsirion Would be okay if we ignore test_gateway_can_pay_ldk_node so we don't have a bunch of flakes on master? We can remove the #[ignore] in #4354 before merging.

[m1sterc001guy]

I can help debug the flaky ldk-node test

[bradleystachurski]

removed this pull request from the merge queue due to no response for status checks

We may need to increase the status check timeout: https://github.com/orgs/community/discussions/47293

Can someone with permissions try increasing?

[bradleystachurski]

Can someone with permissions try increasing?

Actually let's hold off increasing. Seeing other PRs fail with the same no response error, so might be a clogged merge queue.