Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run real fedimint-ln-gateway tests #4388

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix: run real fedimint-ln-gateway tests #4388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05fedb6
fix: run real fedimint-ln-gateway tests
bradleystachurski Feb 21, 2024
e681361
chore: disable flakey test_gateway_can_pay_ldk_node
bradleystachurski Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions gateway/ln-gateway/tests/integration_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ async fn pay_valid_invoice(
}

#[tokio::test(flavor = "multi_thread")]
#[ignore] // TODO: resolve in https://github.com/fedimint/fedimint/pull/4354
async fn test_gateway_can_pay_ldk_node() -> anyhow::Result<()> {
// Running LDK Node with the mock services doesnt provide any additional
// coverage, since `FakeLightningTest` does not open any channels.
Expand Down
3 changes: 2 additions & 1 deletion scripts/tests/backend-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ function run_tests() {
-E 'package(fedimint-ln-tests)'
cargo nextest run --locked --workspace --all-targets \
${CARGO_PROFILE:+--cargo-profile ${CARGO_PROFILE}} ${CARGO_PROFILE:+--profile ${CARGO_PROFILE}} \
${TEST_ARGS_SERIALIZED} 'package(ln-gateway)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So was this a no-op?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct 馃憤

${TEST_ARGS_SERIALIZED} \
-E 'package(fedimint-ln-gateway)'
>&2 echo "### Testing against bitcoind - complete"
fi

Expand Down