Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use fedimint's overlay #378

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Feb 17, 2024

No description provided.

@dpc dpc requested review from a team as code owners February 17, 2024 00:49
@dpc
Copy link
Contributor Author

dpc commented Feb 17, 2024

@justinmoon

@bradleystachurski bradleystachurski merged commit 8713bb8 into fedimint:master Feb 17, 2024
1 check passed
@justinmoon
Copy link
Contributor

justinmoon commented Feb 19, 2024

@dpc we still need to backport this. 0.2 branch is where the flake is broken on MacOS. This PR was attempting to fix it: #377

Some issues with the backport in fedimint fedimint/fedimint#4349

url =
"github:fedimint/fedimint?rev=9ec5418ee002134188d4584cc645fe1b5ffba4f1";
"github:dpc/fedimint?rev=678d456a1e242fb952b92514f0e6a83083a9704d";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpc taking over the UI repo :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should have a CI check that our flake inputs always use a tag to specify the dependency? When it's just a git hash, you can't tell by inspection what version is being used ...

@justinmoon
Copy link
Contributor

I still can't run nix develop on master (8713bb828f050f18c386abd200e5b17ef7a8d844):

$ nix develop
error: builder for '/nix/store/0f3p440vzing4xpdf9j37kq34z110hjz-bitcoind-26.0.drv' failed with exit code 2;
       last 10 log lines:
       > ./support/allocators/pool.h:250:15: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.14 or newer
       >             ::operator delete (p, std::align_val_t{alignment});
       >               ^
       > ./support/allocators/pool.h:250:15: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic
       > 4 errors generated.
       > make[2]: *** [Makefile:10024: libbitcoin_node_a-blockencodings.o] Error 1
       > make[2]: Leaving directory '/private/tmp/nix-build-bitcoind-26.0.drv-0/bitcoin-26.0/src'
       > make[1]: *** [Makefile:20138: all-recursive] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-bitcoind-26.0.drv-0/bitcoin-26.0/src'
       > make: *** [Makefile:814: all-recursive] Error 1
       For full logs, run 'nix log /nix/store/0f3p440vzing4xpdf9j37kq34z110hjz-bitcoind-26.0.drv'.
error: 1 dependencies of derivation '/nix/store/y5pxhj8q1536kihb72ms39n7cfx0n9f5-nix-shell-env.drv' failed to build

@Kodylow
Copy link
Member

Kodylow commented Feb 21, 2024

I was able to build with this commit : a9e807e4e0325ce8d93d4af212309a183e87d89a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants