Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix nix flake #377

Closed
wants to merge 1 commit into from
Closed

feat: fix nix flake #377

wants to merge 1 commit into from

Conversation

justinmoon
Copy link
Contributor

@justinmoon justinmoon commented Feb 16, 2024

This happens currently on mac:

$ nix develop
error: builder for '/nix/store/0f3p440vzing4xpdf9j37kq34z110hjz-bitcoind-26.0.drv' failed with exit code 2;
       last 10 log lines:
       > 4 errors generated.
       > 4 errors generated.
       > make[2]: *** [Makefile:11130: libbitcoin_node_a-txmempool.o] Error 1
       > make[2]: *** [Makefile:10864: libbitcoin_node_a-rest.o] Error 1
       > 4 errors generated.
       > make[2]: *** [Makefile:10234: libbitcoin_node_a-init.o] Error 1
       > make[2]: Leaving directory '/private/tmp/nix-build-bitcoind-26.0.drv-0/bitcoin-26.0/src'
       > make[1]: *** [Makefile:20138: all-recursive] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-bitcoind-26.0.drv-0/bitcoin-26.0/src'
       > make: *** [Makefile:814: all-recursive] Error 1
       For full logs, run 'nix log /nix/store/0f3p440vzing4xpdf9j37kq34z110hjz-bitcoind-26.0.drv'.
error: 1 dependencies of derivation '/nix/store/jxi7hv8zmmnb2bcpsa9vz5cg8a5vq051-nix-shell-env.drv' failed to build

@justinmoon justinmoon requested a review from a team as a code owner February 16, 2024 04:30
@justinmoon justinmoon changed the base branch from master to releases/v0.2 February 16, 2024 04:30
@justinmoon justinmoon marked this pull request as draft February 16, 2024 04:30
@okjodom
Copy link
Collaborator

okjodom commented Feb 19, 2024

what is broken on the current flake?

@justinmoon
Copy link
Contributor Author

Doesn't build on MacOS. Sorry I didn't fill out the description better. Late night debugging in discord. https://discord.com/channels/990354215060795454/1096102512169328753/1207888989105684500

@justinmoon
Copy link
Contributor Author

I believe this depends on fedimint/fedimint#4349

@Kodylow
Copy link
Member

Kodylow commented Feb 21, 2024

closing this for working #381

@Kodylow Kodylow closed this Feb 21, 2024
@justinmoon
Copy link
Contributor Author

closing this for working #381

I think this PR should be closed, but to be clear #381 fixes master and this PR fixes releases/v0.2 so we still need to fix releases/v0.2.

@Kodylow
Copy link
Member

Kodylow commented Feb 21, 2024

should we use that same working commit or a different one? and do we actually need to fix it on the release, it's just a dev env issue?

@justinmoon
Copy link
Contributor Author

We don't need to fix v0.2 if you we won't need to change it at all. Perhaps it's good enough as-is. It seemed like you wanted to change something on v0.2 but maybe I was mistaken.

@Kodylow
Copy link
Member

Kodylow commented Feb 22, 2024

no just needed to change to to get the dev environment working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants