Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/resalloc/pools returns 500 #2882

Closed
nikromen opened this issue Aug 17, 2023 · 2 comments · Fixed by praiskup/resalloc#126
Closed

/resalloc/pools returns 500 #2882

nikromen opened this issue Aug 17, 2023 · 2 comments · Fixed by praiskup/resalloc#126
Labels
bug easyfix

Comments

@nikromen
Copy link
Member

see https://download.copr.fedorainfracloud.org/resalloc/pools
FrostyX added a commit to FrostyX/resalloc that referenced this issue Sep 16, 2023
@FrostyX
webui: fix traceback from the pools page
2021dcb 
Fix fedora-copr/copr#2882

Since we have on-demand resources, the `reload_config` now returns a
tuple. See how it is used in `resallocserver.manager`.
@FrostyX FrostyX mentioned this issue Sep 16, 2023
Merged
@FrostyX
Copy link
Member

FrostyX commented Sep 16, 2023

The traceback is:

Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 2525, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1822, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1820, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1796, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/resallocwebui/app.py", line 47, in pools
    sys.stderr.write(pools_config)
TypeError: write() argument must be str, not tuple

Fixing it in praiskup/resalloc#126

praiskup pushed a commit to praiskup/resalloc that referenced this issue Sep 18, 2023
@FrostyX @praiskup
webui: fix traceback from the pools page
3906152 
Fix fedora-copr/copr#2882

Since we have on-demand resources, the `reload_config` now returns a
tuple. See how it is used in `resallocserver.manager`.
@praiskup
Copy link
Member

praiskup commented Oct 9, 2023

I'm reopening, we still want to release a new version and deploy to production.

@praiskup praiskup reopened this Oct 9, 2023
@praiskup praiskup mentioned this issue Nov 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easyfix
Projects
CPT Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

webui: fix traceback from the pools page FrostyX/resalloc
3 participants
@FrostyX @praiskup @nikromen