Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sourceforge (git) backend to retrieve git tags #1134

Merged
merged 1 commit into from Jul 20, 2021
Merged

Add sourceforge (git) backend to retrieve git tags #1134

merged 1 commit into from Jul 20, 2021

Conversation

LenkaSeg
Copy link
Contributor

@LenkaSeg LenkaSeg commented Jul 13, 2021 •
edited by Zlopez

New module handling the extraction of git tags from Sourceforge.net

Closes #223

@LenkaSeg LenkaSeg requested a review from a team as a code owner July 13, 2021 12:42
@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2021

This pull request introduces 1 alert when merging af76744 into 4a2ed6c - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@LenkaSeg
Copy link
Contributor Author

Oops, forgot to write tests for it :)

Zlopez
Zlopez requested changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing in documentation

docs/user-guide.rst Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link

Build succeeded.

Zlopez
Zlopez requested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, just found a few small typos in comments.

anitya/lib/backends/sourceforge_git.py
% (url, project.name, git_tag_request.status_code)
)

soup = BeautifulSoup(git_tag_request.content, "html.parser")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach with BeatifulSoup is really nice. I wonder why it's not used in some other backends.

anitya/tests/lib/backends/test_sourceforge_git.py Outdated Show resolved Hide resolved
anitya/tests/lib/backends/test_sourceforge_git.py Outdated Show resolved Hide resolved
@LenkaSeg
Copy link
Contributor Author

I hope I fixed all the comments.
I noticed there is one condition missing in backends/sourceforge_git:get_namespace_repo, so I added that too.

@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

@Zlopez
Copy link
Contributor

Zlopez commented Jul 20, 2021

Just fix the failing diff-cover and we can merge this.

@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

@LenkaSeg
Add sourceforge (git) backend to retrieve git tags
95ada1e 
New module handling the extraction of git tags from Sourceforge.net
@softwarefactory-project-zuul
Copy link

Build succeeded.

@mergify mergify bot merged commit fc93f8a into fedora-infra:master Jul 20, 2021
@Zlopez Zlopez mentioned this pull request Jul 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlopez Zlopez Zlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for (SourceForge) git tags
2 participants
@LenkaSeg @Zlopez