Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the Web UI to handle multiple content types #1329

Closed
bowlofeggs opened this issue Mar 3, 2017 · 3 comments · Fixed by #1548
Closed

Modify the Web UI to handle multiple content types #1329

bowlofeggs opened this issue Mar 3, 2017 · 3 comments · Fixed by #1548
Assignees
@bowlofeggs
Labels
High priority These issues are higher priority than normal HTML Issues pertaining to Bodhi's HTML JS Issues pertaining to Bodhi's JavaScript code Refactor Issues that are a refactor to improve maintainability for Bodhi RFE Requests for Enhancement
Milestone
Modularity support

Comments

@bowlofeggs
Copy link
Contributor

We will need to alter the web interface to handle multiple content types.
@bowlofeggs bowlofeggs added Gibson High priority These issues are higher priority than normal HTML Issues pertaining to Bodhi's HTML JS Issues pertaining to Bodhi's JavaScript code Refactor Issues that are a refactor to improve maintainability for Bodhi RFE Requests for Enhancement labels Mar 3, 2017
@bowlofeggs bowlofeggs added this to the Multi-type support (Bodhi 3.0.0?) milestone Mar 3, 2017
@lmacken lmacken mentioned this issue Mar 3, 2017
Closed
10 tasks
@bowlofeggs
Copy link
Contributor Author

@ryanlerch @ralphbean I don't have many ideas for this, other than to slap some text in the right hand info box that says what kind of update it is. For a second I considered trying to come up with icons for each update type, but I can't imagine what an icon for an RPM or a module might look like.

Do either of you think more than just displaying text about the type is needed?

@bowlofeggs bowlofeggs self-assigned this May 25, 2017
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue May 25, 2017
@bowlofeggs
Display the content type of updates in the UI.
08047f8 
fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue May 25, 2017
@bowlofeggs
Display the content type of updates in the UI.
76155a3 
fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue May 25, 2017
@bowlofeggs
Display the content type of updates in the UI.
a105ee1 
fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
@bowlofeggs bowlofeggs mentioned this issue May 25, 2017
Merged
@ryanlerch
Copy link
Collaborator

Yeah, I think we are left to text here. The only thing we could use for RPM is the package icon, and we are already using it for New Package. and Module would be even more abstract Ithink...

@ralphbean
Copy link
Contributor

Text works for me. :)

bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue May 30, 2017
@bowlofeggs
Display the content type of updates in the UI.
da86b63 
fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue May 30, 2017
@bowlofeggs
Display the content type of updates in the UI.
48a58f2 
fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue May 30, 2017
@bowlofeggs
Display the content type of updates in the UI.
2515cd4 
fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue May 30, 2017
@bowlofeggs
Display the content type of updates in the UI.
553113d 
This commit also adjusts the return type of
bodhi.server.models.Update.content_type from a basestring to a
bodhi.server.models.ContentType, so that it can be used both
programmatically and for human display.

fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs added a commit to bowlofeggs/bodhi that referenced this issue Jun 7, 2017
@bowlofeggs
Display the content type of updates in the UI.
c6c2a1c 
This commit also adjusts the return type of
bodhi.server.models.Update.content_type from a basestring to a
bodhi.server.models.ContentType, so that it can be used both
programmatically and for human display.

fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
mcurlej pushed a commit to mcurlej/bodhi that referenced this issue Sep 4, 2017
@bowlofeggs @mcurlej
Display the content type of updates in the UI.
a272398 
This commit also adjusts the return type of
bodhi.server.models.Update.content_type from a basestring to a
bodhi.server.models.ContentType, so that it can be used both
programmatically and for human display.

fixes fedora-infra#1329

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bowlofeggs bowlofeggs

Labels
High priority These issues are higher priority than normal HTML Issues pertaining to Bodhi's HTML JS Issues pertaining to Bodhi's JavaScript code Refactor Issues that are a refactor to improve maintainability for Bodhi RFE Requests for Enhancement
Projects
None yet
Milestone
Modularity support
Development

Successfully merging a pull request may close this issue.

Display the content type of updates in the UI. bowlofeggs/bodhi
3 participants
@ralphbean @bowlofeggs @ryanlerch