Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bodhi-push will happily resume Composes that are not in a stopped state #2579

Open
bowlofeggs opened this issue Sep 11, 2018 · 0 comments
Open
Assignees
Labels
Composer Issues related to the composer Crash Issues related to an unhandled crash High priority These issues are higher priority than normal

Comments

@bowlofeggs
Copy link
Contributor

bodhi-push does not prevent or warn users when they ask it to resume a compose that isn't in a stopped state (which I think would only include the failed state). This is bad because the backend will happily run two simultaneous composes if asked to do so.

We should make it error if the compose isn't in a stopped state, or at least warn. I lean towards erroring and refusing, but there are situations (such as fedmsg-hub stopping) where composes could get left in what appears to be a running state even when they are not running, and it would be nice if there were a way to force it to start over.

@bowlofeggs bowlofeggs added Critical We can't go on living in this sqalor, drop everything and fix it! Composer Issues related to the composer Crash Issues related to an unhandled crash High priority These issues are higher priority than normal and removed Critical We can't go on living in this sqalor, drop everything and fix it! labels Sep 11, 2018
@ryanlerch ryanlerch self-assigned this Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Composer Issues related to the composer Crash Issues related to an unhandled crash High priority These issues are higher priority than normal
Projects
None yet
Development

No branches or pull requests

2 participants