Update bodhi-push to only resume failed composes #2670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowlofeggs
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
Can you amend your commit message to sign the Developer Certificate of Origin as described here?
| ', '.join([str(c) for c in session.query(Compose).all()])), abort=True) | ||
| if not resume and session.query(Compose).filter(Compose.state == ComposeState.failed).count(): | ||
| click.confirm('Failed composes detected: {}. Do you wish to resume them all?'.format( | ||
| ', '.join([str(c) for c in session.query(Compose).filter(Compose.state == ComposeState.failed).all()])), abort=True) |
There was a problem hiding this comment.
I would probably make the query match non-failed composes instead of detecting failed ones. We could then print a warning and exit, something like "WARNING: running composes detected, refusing to resume as that is a dangerous operation. If you are sure they are not really running, you can re-run with the --force flag." Of course, this would require a --force flag to be added as well.
| resume = True | ||
| resume_all = True | ||
|
|
||
| # If we're resuming a push | ||
| if resume: | ||
| for compose in session.query(Compose).all(): | ||
| for compose in session.query(Compose).filter(Compose.state == ComposeState.failed).all(): |
There was a problem hiding this comment.
If we add a --force flag, we would want to respect that here as well.
|
Hey @ryanlerch! Do you still want to work on this? |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates bodhi-push so it only resumes failed composes. This, however does not allow the user to restart other composes that might be failed.
Any ideas on how to re-structure this to allow both use-cases?
Fixes #2579