Document the mail.templates_basepath setting. #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebwoj
suggested changes
Jan 15, 2019
production.ini
Outdated
| @@ -126,6 +126,11 @@ use = egg:bodhi-server | |||
| # domain for generated message IDs | |||
| # message_id_email_domain = admin.fedoraproject.org | |||
|
|
|||
| # Where to search for e-mail templates. Eash release has an attribute that defines the name of a | |||
There was a problem hiding this comment.
Good catch, fixed!
bowlofeggs
force-pushed
the
mail_templates_setting
branch
2 times, most recently
from
7d066d3
to
a7a1d3a
Compare
pypingou
reviewed
Jan 17, 2019
production.ini
Outdated
| @@ -126,6 +126,11 @@ use = egg:bodhi-server | |||
| # domain for generated message IDs | |||
| # message_id_email_domain = admin.fedoraproject.org | |||
|
|
|||
| # Where to search for e-mail templates. Each release has an attribute that defines the name of a | |||
There was a problem hiding this comment.
Would it be worth documenting which attribute that is?
There was a problem hiding this comment.
@pypingou I'm applying this patch to document that attribute:
diff --git a/production.ini b/production.ini
index b2e57d9e..891bd1f8 100644
--- a/production.ini
+++ b/production.ini
@@ -126,8 +126,9 @@ use = egg:bodhi-server
# domain for generated message IDs
# message_id_email_domain = admin.fedoraproject.org
-# Where to search for e-mail templates. Each release has an attribute that defines the name of a
-# mail template, and Bodhi will look in the path defined by this setting to find the named template.
+# Where to search for e-mail templates. Each release has a mail_template attribute that defines the
+# name of a mail template, and Bodhi will look in the path defined by this setting to find the named
+# template.
# mail.templates_basepath = bodhi:server/email/templates/
a7a1d3a
to
1ddd09a
Compare
Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs
force-pushed
the
mail_templates_setting
branch
from
1ddd09a
to
330c443
Compare
|
This patch is planned for inclusion in the upcoming 4.0.0 release: #3221 |
|
Bodhi 4.0.0 beta is built and deployed to staging: https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Randy Barlow randy@electronsweatshop.com