New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog entry to update notes for automatic updates #3548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, only some minor things I'd change. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor nitpicking this time. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
@ryanlerch I'm not sure why the integration tests fail here (something timed out), on my Vagrant box they succeed. I'll "empty-amend"* and force-push so the CI pipeline conducts the tests again. *: i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there will be some user-visible change, I think that this change should be listed in the next release notes. Please add a file in the news
directory as explained in this documentation. Thanks!
move changelog generation from mail.py to util.py then, Add changelog to update notes for automatic updates Fixes: #3192 Signed-off-by: Ryan Lerch <rlerch@redhat.com>
DOne! thanks! |
This abstracts out the code in mail.py that generates the changelog entry, and puts it in util.py so we can use it in other places. Then, this new abstraction is used to add a changelog entry to the updates notes of automatic updates.
Fixes: #3192