Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry to update notes for automatic updates #3548

Merged
merged 1 commit into from Oct 18, 2019
Merged

Add changelog entry to update notes for automatic updates #3548

merged 1 commit into from Oct 18, 2019

Conversation

ryanlerch
Copy link
Collaborator

@ryanlerch ryanlerch commented Oct 10, 2019

This abstracts out the code in mail.py that generates the changelog entry, and puts it in util.py so we can use it in other places. Then, this new abstraction is used to add a changelog entry to the updates notes of automatic updates.

Fixes: #3192

@ryanlerch ryanlerch requested a review from a team as a code owner October 10, 2019 06:37
@ryanlerch ryanlerch added this to Need Review in CI Gating Oct 10, 2019
@nphilipp nphilipp self-assigned this Oct 10, 2019
Copy link
Member

@nphilipp nphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, only some minor things I'd change. Thanks!

bodhi/server/util.py Outdated Show resolved Hide resolved
bodhi/server/util.py Outdated Show resolved Hide resolved
bodhi/tests/server/consumers/test_automatic_updates.py Outdated Show resolved Hide resolved
bodhi/server/consumers/automatic_updates.py Outdated Show resolved Hide resolved
Copy link
Member

@nphilipp nphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor nitpicking this time. 😉

bodhi/server/util.py Outdated Show resolved Hide resolved
bodhi/server/util.py Outdated Show resolved Hide resolved
Copy link
Member

@nphilipp nphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@nphilipp
Copy link
Member

@ryanlerch I'm not sure why the integration tests fail here (something timed out), on my Vagrant box they succeed. I'll "empty-amend"* and force-push so the CI pipeline conducts the tests again.

*: i.e. git commit --amend --no-edit && git push --force which will just update the timestamp of the latest commit, to make the CI pipeline do the tests again.

Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there will be some user-visible change, I think that this change should be listed in the next release notes. Please add a file in the news directory as explained in this documentation. Thanks!

move changelog generation from mail.py to util.py
then, Add changelog to update notes for automatic updates

Fixes: #3192

Signed-off-by: Ryan Lerch <rlerch@redhat.com>
@ryanlerch
Copy link
Collaborator Author

Since there will be some user-visible change, I think that this change should be listed in the next release notes. Please add a file in the news directory as explained in this documentation. Thanks!

DOne! thanks!

@mergify mergify bot merged commit 54210f7 into fedora-infra:develop Oct 18, 2019
CI Gating automation moved this from Need Review to Merged to develop Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
CI Gating
  
Merged to develop
Development

Successfully merging this pull request may close these issues.

Automatic updates should be filled with information from the RPM changelog
3 participants